public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>
Subject: Re: Installing kernel headers in kvm-kmod
Date: Thu, 10 Dec 2009 17:01:03 +0200	[thread overview]
Message-ID: <4B210D2F.3060607@redhat.com> (raw)
In-Reply-To: <200912101550.22930.arnd@arndb.de>

On 12/10/2009 04:50 PM, Arnd Bergmann wrote:
> On Thursday 10 December 2009, Jan Kiszka wrote:
>    
>> Anthony Liguori wrote:
>>      
>>> QEMU 0.12.0-rc1 does not support KVM
>>> https://bugs.launchpad.net/bugs/494500
>>>
>>> Boils down to the fact that 1) we don't include kernel headers in qemu
>>> (whereas qemu-kvm does) and 2) kvm-kmod does not install those headers
>>> on make install.
>>>
>>> I think we've discussed (2) as being the preferred solution.  Does
>>> everyone agree with that?  Anyone care to volunteer to make the change? :-)
>>>
>>>        
>> I've pushed a half-tested approach into kvm-kmod's next branch. Feel
>> free to test/fix/enhance it.
>>      
> This would work, but installing to /usr/include/linux/kvm.h will confuse
> distro package managers a lot, because that location belongs to the glibc
> or libc-linux-headers or some other package already.
>
> If you want to install the headers from kvm-kmod, I would recommend
> doing it in a different path, e.g. /usr/include/kvm-kmod/{linux,asm}.
>    

Maybe even /usr/local/include/kvm-kmod-$version/...., and a symlink 
/usr/local/include/kvm-kmod.

> qemu can then add -I/usr/include/kvm-kmod to it's default include
> path and get the kvm-kmod version if that's installed or the distro
> version otherwise.
>
> It may also be useful to do the equivalent of 'make headers_install'
> from the kernel, to remove all "#ifdef __KERNEL__" sections and
> sparse annotations from the header files, but it should also work
> without that.
>    

Well, qemu.git needs __user removed.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-12-10 15:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10 13:07 Installing kernel headers in kvm-kmod Anthony Liguori
2009-12-10 13:12 ` Avi Kivity
2009-12-10 13:35 ` Jan Kiszka
2009-12-10 14:50   ` Arnd Bergmann
2009-12-10 15:01     ` Avi Kivity [this message]
2009-12-10 15:25       ` Arnd Bergmann
2009-12-10 16:42         ` Jan Kiszka
2009-12-10 16:44           ` Avi Kivity
2009-12-10 17:14             ` Jan Kiszka
2009-12-10 20:26               ` Arnd Bergmann
2009-12-10 20:36                 ` Avi Kivity
2009-12-10 21:44       ` Anthony Liguori
2009-12-10 15:01     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B210D2F.3060607@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=arnd@arndb.de \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox