From: Jan Kiszka <jan.kiszka@siemens.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: Installing kernel headers in kvm-kmod
Date: Thu, 10 Dec 2009 16:01:35 +0100 [thread overview]
Message-ID: <4B210D4F.80700@siemens.com> (raw)
In-Reply-To: <200912101550.22930.arnd@arndb.de>
Arnd Bergmann wrote:
> On Thursday 10 December 2009, Jan Kiszka wrote:
>> Anthony Liguori wrote:
>>> QEMU 0.12.0-rc1 does not support KVM
>>> https://bugs.launchpad.net/bugs/494500
>>>
>>> Boils down to the fact that 1) we don't include kernel headers in qemu
>>> (whereas qemu-kvm does) and 2) kvm-kmod does not install those headers
>>> on make install.
>>>
>>> I think we've discussed (2) as being the preferred solution. Does
>>> everyone agree with that? Anyone care to volunteer to make the change? :-)
>>>
>> I've pushed a half-tested approach into kvm-kmod's next branch. Feel
>> free to test/fix/enhance it.
>
> This would work, but installing to /usr/include/linux/kvm.h will confuse
> distro package managers a lot, because that location belongs to the glibc
> or libc-linux-headers or some other package already.
>
> If you want to install the headers from kvm-kmod, I would recommend
> doing it in a different path, e.g. /usr/include/kvm-kmod/{linux,asm}.
> qemu can then add -I/usr/include/kvm-kmod to it's default include
> path and get the kvm-kmod version if that's installed or the distro
> version otherwise.
Good point. /usr/include/kvm-kmod would be ok for me unless someone
wants them elsewhere.
>
> It may also be useful to do the equivalent of 'make headers_install'
> from the kernel, to remove all "#ifdef __KERNEL__" sections and
> sparse annotations from the header files, but it should also work
> without that.
Yes, I think it's better to let the sync source install those headers
for us, then pick up those cleaned versions, carry them in kvm-kmod in
addition to the existing ones and finally install them.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2009-12-10 15:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 13:07 Installing kernel headers in kvm-kmod Anthony Liguori
2009-12-10 13:12 ` Avi Kivity
2009-12-10 13:35 ` Jan Kiszka
2009-12-10 14:50 ` Arnd Bergmann
2009-12-10 15:01 ` Avi Kivity
2009-12-10 15:25 ` Arnd Bergmann
2009-12-10 16:42 ` Jan Kiszka
2009-12-10 16:44 ` Avi Kivity
2009-12-10 17:14 ` Jan Kiszka
2009-12-10 20:26 ` Arnd Bergmann
2009-12-10 20:36 ` Avi Kivity
2009-12-10 21:44 ` Anthony Liguori
2009-12-10 15:01 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B210D4F.80700@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=anthony@codemonkey.ws \
--cc=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox