From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: Installing kernel headers in kvm-kmod Date: Thu, 10 Dec 2009 16:01:35 +0100 Message-ID: <4B210D4F.80700@siemens.com> References: <4B20F27D.3000006@codemonkey.ws> <4B20F914.8020003@siemens.com> <200912101550.22930.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Avi Kivity , Marcelo Tosatti , kvm-devel To: Arnd Bergmann Return-path: Received: from david.siemens.de ([192.35.17.14]:15749 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753479AbZLJPBq (ORCPT ); Thu, 10 Dec 2009 10:01:46 -0500 In-Reply-To: <200912101550.22930.arnd@arndb.de> Sender: kvm-owner@vger.kernel.org List-ID: Arnd Bergmann wrote: > On Thursday 10 December 2009, Jan Kiszka wrote: >> Anthony Liguori wrote: >>> QEMU 0.12.0-rc1 does not support KVM >>> https://bugs.launchpad.net/bugs/494500 >>> >>> Boils down to the fact that 1) we don't include kernel headers in qemu >>> (whereas qemu-kvm does) and 2) kvm-kmod does not install those headers >>> on make install. >>> >>> I think we've discussed (2) as being the preferred solution. Does >>> everyone agree with that? Anyone care to volunteer to make the change? :-) >>> >> I've pushed a half-tested approach into kvm-kmod's next branch. Feel >> free to test/fix/enhance it. > > This would work, but installing to /usr/include/linux/kvm.h will confuse > distro package managers a lot, because that location belongs to the glibc > or libc-linux-headers or some other package already. > > If you want to install the headers from kvm-kmod, I would recommend > doing it in a different path, e.g. /usr/include/kvm-kmod/{linux,asm}. > qemu can then add -I/usr/include/kvm-kmod to it's default include > path and get the kvm-kmod version if that's installed or the distro > version otherwise. Good point. /usr/include/kvm-kmod would be ok for me unless someone wants them elsewhere. > > It may also be useful to do the equivalent of 'make headers_install' > from the kernel, to remove all "#ifdef __KERNEL__" sections and > sparse annotations from the header files, but it should also work > without that. Yes, I think it's better to let the sync source install those headers for us, then pick up those cleaned versions, carry them in kvm-kmod in addition to the existing ones and finally install them. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux