From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Installing kernel headers in kvm-kmod Date: Thu, 10 Dec 2009 22:36:43 +0200 Message-ID: <4B215BDB.7000600@redhat.com> References: <4B20F27D.3000006@codemonkey.ws> <4B21257B.6030008@redhat.com> <4B212C80.2020802@siemens.com> <200912102026.34997.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Anthony Liguori , Marcelo Tosatti , kvm-devel To: Arnd Bergmann Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17508 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755841AbZLJUgq (ORCPT ); Thu, 10 Dec 2009 15:36:46 -0500 In-Reply-To: <200912102026.34997.arnd@arndb.de> Sender: kvm-owner@vger.kernel.org List-ID: On 12/10/2009 10:26 PM, Arnd Bergmann wrote: > On Thursday 10 December 2009 17:14:40 Jan Kiszka wrote: > >> Avi Kivity wrote: >> >>> On 12/10/2009 06:42 PM, Jan Kiszka wrote: >>> >>>> I've just (forced-)pushed the "simple" version with >>>> /usr/include/kvm-kmod as destination. The user headers are now stored >>>> under usr/include in the kvm-kmod sources and installed from there. >>>> >>>> >>> It's customary to install to /usr/local, not to /usr (qemu does the same). >>> > Right. Specifically, an install from source should go to /usr/local/include > by default, while a distro package should override the path to go to > /usr/include, which the current version easily allows. > > This also means that qemu will have to look in three places now, > /usr/local/include/kvm-kmod, /usr/include/kvm-kmod and /usr/include. > Adding /usr/local/include probably doesn't hurt but should not be > necessary. > The only icky bit is that /usr/local/include/kvm-kmod will stick around after the user forgets about it and switches to the kernel headers. I don't see a way around it (it's the generic uninstall problem), so I think we should just live with it. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.