From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: Fix possible circular locking in kvm_vm_ioctl_assign_device()
Date: Mon, 14 Dec 2009 11:36:51 +0200
Message-ID: <4B260733.6080203@redhat.com>
References: <1260176284-4858-1-git-send-email-sheng@linux.intel.com> <200912141514.00291.sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:15938 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751224AbZLNJgy (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 14 Dec 2009 04:36:54 -0500
In-Reply-To: <200912141514.00291.sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/14/2009 09:14 AM, Sheng Yang wrote:
> On Monday 07 December 2009 16:58:04 Sheng Yang wrote:
>    
>> One possible order is:
>>
>> KVM_CREATE_IRQCHIP ioctl(took kvm->lock) ->  kvm_iobus_register_dev() ->
>> down_write(kvm->slots_lock).
>>
>> The other one is in kvm_vm_ioctl_assign_device(), which take
>>   kvm->slots_lock first, then kvm->lock.
>>
>> Observe it due to kernel locking debug warnings.
>>
>> Signed-off-by: Sheng Yang<sheng@linux.intel.com>
>>      
> Avi? Marcelo?
>
>    

Sorry, hunting a regression so the tree is frozen.  Will review soon.

-- 
error compiling committee.c: too many arguments to function