From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Trap and invalid MWAIT/MONITOR instruction Date: Tue, 15 Dec 2009 11:26:22 +0200 Message-ID: <4B27563E.1020602@redhat.com> References: <1260854994-7661-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:3481 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759387AbZLOJ0Y (ORCPT ); Tue, 15 Dec 2009 04:26:24 -0500 In-Reply-To: <1260854994-7661-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/15/2009 07:29 AM, Sheng Yang wrote: > We don't support these instructions, but guest can execute them even if the > feature('monitor') haven't been exposed in CPUID. So we would trap and inject > a #UD if guest try this way. > > CPU_BASED_MOV_DR_EXITING | > CPU_BASED_USE_TSC_OFFSETING | > + CPU_BASED_MWAIT_EXITING | > + CPU_BASED_MONITOR_EXITING | > CPU_BASED_INVLPG_EXITING; > opt = CPU_BASED_TPR_SHADOW | > CPU_BASED_USE_MSR_BITMAPS | > Shouldn't these be in the 'opt' section? Not all processors support MONITOR/MWAIT exiting (presumably those don't support the instructions). -- error compiling committee.c: too many arguments to function