Re: network shutdown under heavy load

[rek2 <rek2@binaryfreedom.info>]

You  say this version.. is there a newer version with this patch already 
apply to it?

Thanks



On 12/17/09 20:27 p.m., Herbert Xu wrote:
> On Thu, Dec 17, 2009 at 01:15:46PM -0500, rek2 wrote:
>    
>> I been told that today the network when down again and one of the guys
>> here had to log using the console and restart it for that particular
>> guests..
>>
>> on the guest:
>>   uname -a
>> Linux XXXX 2.6.27.25-170.2.72.fc10.x86_64 #1 SMP Sun Jun 21 18:39:34 EDT
>> 2009 x86_64 x86_64 x86_64 GNU/Linux
>>
>> Next time it goes down I will try to run a sniffer and try both sides.
>>      
> OK I'm fairly sure this version has a buggy virtio-net.  Does
> this patch (if it applies :) help?
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9eec5a5..74b3854 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -521,8 +521,10 @@ static void xmit_tasklet(unsigned long data)
>   		vi->svq->vq_ops->kick(vi->svq);
>   		vi->last_xmit_skb = NULL;
>   	}
> -	if (vi->free_in_tasklet)
> +	if (vi->free_in_tasklet) {
>   		free_old_xmit_skbs(vi);
> +		netif_wake_queue(vi->dev);
> +	}
>   	netif_tx_unlock_bh(vi->dev);
>   }
>
> Cheers,
>