[ANNOUNCE] qemu-kvm-0.12.1.1

[ANNOUNCE] qemu-kvm-0.12.1.1

[Avi Kivity]

qemu-kvm-0.12.1.1 is now available.  This release is is based on the 
upstream qemu 0.12.1, plus kvm-specific enhancements.  Please see the 
original qemu 0.12.1 release announcement for details.

This release can be used with the kvm kernel modules provided by your 
distribution kernel, or by the modules in the kvm-kmod package, such as 
kvm-kmod-2.6.32.

Changes from qemu-kvm-0.12.1
- fix build error due to missing kvm_save_mpstate() on some configurations
- fix option rom loading (fixes boot=on)


http://www.linux-kvm.org

-- 
error compiling committee.c: too many arguments to function

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Nikola Ciprich]

sorry to bring bad news, but it still doesn't compile (at least for me):

[root@vmdev03 qemu-kvm-0.12.1.1]# make
  LINK  x86_64-softmmu/qemu-system-x86_64
machine.o: In function `cpu_pre_save':
/usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [subdir-x86_64-softmmu] Error 2

n.

On Tue, Dec 22, 2009 at 02:50:03PM +0200, Avi Kivity wrote:
> qemu-kvm-0.12.1.1 is now available.  This release is is based on the
> upstream qemu 0.12.1, plus kvm-specific enhancements.  Please see
> the original qemu 0.12.1 release announcement for details.
> 
> This release can be used with the kvm kernel modules provided by
> your distribution kernel, or by the modules in the kvm-kmod package,
> such as kvm-kmod-2.6.32.
> 
> Changes from qemu-kvm-0.12.1
> - fix build error due to missing kvm_save_mpstate() on some configurations
> - fix option rom loading (fixes boot=on)
> 
> 
> http://www.linux-kvm.org
> 
> -- 
> error compiling committee.c: too many arguments to function
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Avi Kivity]

On 12/22/2009 03:35 PM, Nikola Ciprich wrote:
> sorry to bring bad news, but it still doesn't compile (at least for me):
>
> [root@vmdev03 qemu-kvm-0.12.1.1]# make
>    LINK  x86_64-softmmu/qemu-system-x86_64
> machine.o: In function `cpu_pre_save':
> /usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
> collect2: ld returned 1 exit status
> make[1]: *** [qemu-system-x86_64] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
>    

Please provide details about your host.

-- 
error compiling committee.c: too many arguments to function

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Nikola Ciprich]

CentOS5, all packages updated.
But I just noticed build fails only when configured with multiple targets,
including some more exotic (based on fedora spec).
building just using x86_64-softmmu works fine for me.
n.

On Tue, Dec 22, 2009 at 03:43:32PM +0200, Avi Kivity wrote:
> On 12/22/2009 03:35 PM, Nikola Ciprich wrote:
> >sorry to bring bad news, but it still doesn't compile (at least for me):
> >
> >[root@vmdev03 qemu-kvm-0.12.1.1]# make
> >   LINK  x86_64-softmmu/qemu-system-x86_64
> >machine.o: In function `cpu_pre_save':
> >/usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
> >collect2: ld returned 1 exit status
> >make[1]: *** [qemu-system-x86_64] Error 1
> >make: *** [subdir-x86_64-softmmu] Error 2
> 
> Please provide details about your host.
> 
> -- 
> error compiling committee.c: too many arguments to function
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Avi Kivity]

On 12/22/2009 04:07 PM, Nikola Ciprich wrote:
> CentOS5, all packages updated.
> But I just noticed build fails only when configured with multiple targets,
> including some more exotic (based on fedora spec).
> building just using x86_64-softmmu works fine for me.
>    

Okay, so at least it works out of the box (no special configure option).

Hopefully someone will figure out why other targets cause it to fail - 
looks like some files are compiled with the wrong config.h.

-- 
error compiling committee.c: too many arguments to function

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Nikola Ciprich]

Hi Marcelo,
Avi has already fixed this particular problem in the meantime, but
I checked and your patch fixes build problem as well..
thanks!
have a nice day
nik

On Thu, Dec 24, 2009 at 02:25:11PM -0200, Marcelo Tosatti wrote:
> On Tue, Dec 22, 2009 at 03:07:36PM +0100, Nikola Ciprich wrote:
> > CentOS5, all packages updated.
> > But I just noticed build fails only when configured with multiple targets,
> > including some more exotic (based on fedora spec).
> > building just using x86_64-softmmu works fine for me.
> > n.
> > On Tue, Dec 22, 2009 at 03:43:32PM +0200, Avi Kivity wrote:
> > > On 12/22/2009 03:35 PM, Nikola Ciprich wrote:
> > > >sorry to bring bad news, but it still doesn't compile (at least for me):
> > > >
> > > >[root@vmdev03 qemu-kvm-0.12.1.1]# make
> > > >   LINK  x86_64-softmmu/qemu-system-x86_64
> > > >machine.o: In function `cpu_pre_save':
> > > >/usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
> > > >collect2: ld returned 1 exit status
> > > >make[1]: *** [qemu-system-x86_64] Error 1
> > > >make: *** [subdir-x86_64-softmmu] Error 2
> 
> Nikola,
> 
> Can you please confirm the attached patch fixes the undefined reference
> problem for you?
> 
> Thanks
> 

> diff --git a/qemu-kvm.h b/qemu-kvm.h
> index a81ff12..6b3e5a1 100644
> --- a/qemu-kvm.h
> +++ b/qemu-kvm.h
> @@ -1070,6 +1070,7 @@ void kvm_load_tsc(CPUState *env);
>  #endif
>  #define kvm_load_registers(env) do {} while(0)
>  #define kvm_save_registers(env) do {} while(0)
> +#define kvm_save_mpstate(env)   do {} while(0)
>  #define qemu_kvm_cpu_stop(env) do {} while(0)
>  static inline void kvm_init_vcpu(CPUState *env)
>  {


-- 
-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Thomas Treutner]

On Tuesday 22 December 2009 13:50:03 you wrote:
> Changes from qemu-kvm-0.12.1
> - fix build error due to missing kvm_save_mpstate() on some configurations
> - fix option rom loading (fixes boot=on)

Doesn't compile for me with default settings (./configure && make):

  CC    x86_64-softmmu/i386-dis.o
  AR    x86_64-softmmu/libqemu.a
  LINK  x86_64-softmmu/qemu-system-x86_64
/usr/lib/libxenguest.a(xg_private.o): In function `unlock_pages':
(.text+0x470): multiple definition of `unlock_pages'
/usr/lib/libxenctrl.a(xc_private.o):(.text+0x5d0): first defined here
/usr/lib/libxenguest.a(xg_private.o): In function `lock_pages':
(.text+0x4c0): multiple definition of `lock_pages'
/usr/lib/libxenctrl.a(xc_private.o):(.text+0x650): first defined here
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [subdir-x86_64-softmmu] Error 2

Host is Debian Lenny AMD64 with all updates. 

Package: libxen-dev
Status: install ok installed
Priority: extra
Section: libdevel
Installed-Size: 920
Maintainer: Debian Xen Team <pkg-xen-devel@lists.alioth.debian.org>
Architecture: amd64
Source: xen-3
Version: 3.2.1-2
Depends: libxenstore3.0 (= 3.2.1-2)
Description: Public headers and libs for Xen
 This package contains the public headers and static libraries for Xen.


I did --disable-xen to make it work for now, don't need xen-related stuff.


kr,t

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Avi Kivity]

On 12/23/2009 10:16 AM, Thomas Treutner wrote:
> On Tuesday 22 December 2009 13:50:03 you wrote:
>    
>> Changes from qemu-kvm-0.12.1
>> - fix build error due to missing kvm_save_mpstate() on some configurations
>> - fix option rom loading (fixes boot=on)
>>      
> Doesn't compile for me with default settings (./configure&&  make):
>
>    CC    x86_64-softmmu/i386-dis.o
>    AR    x86_64-softmmu/libqemu.a
>    LINK  x86_64-softmmu/qemu-system-x86_64
> /usr/lib/libxenguest.a(xg_private.o): In function `unlock_pages':
> (.text+0x470): multiple definition of `unlock_pages'
> /usr/lib/libxenctrl.a(xc_private.o):(.text+0x5d0): first defined here
> /usr/lib/libxenguest.a(xg_private.o): In function `lock_pages':
> (.text+0x4c0): multiple definition of `lock_pages'
> /usr/lib/libxenctrl.a(xc_private.o):(.text+0x650): first defined here
> collect2: ld returned 1 exit status
> make[1]: *** [qemu-system-x86_64] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
>
>    

It looks like a problem in the Xen library?  Or maybe we're including 
the library twice.

There's no unlock_pages in qemu.

Can you rerun with V=1 to see the full command line?

-- 
error compiling committee.c: too many arguments to function

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Thomas Treutner]

On Wednesday 23 December 2009 09:52:47 you wrote:
> It looks like a problem in the Xen library?  Or maybe we're including
> the library twice.
>
> There's no unlock_pages in qemu.
>
> Can you rerun with V=1 to see the full command line?

Please see here: http://pastebin.com/f4d79c982

(make -j8 vs. just make doesn't make a difference, tested that)...


kr,t

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Avi Kivity]

On 12/23/2009 12:15 PM, Thomas Treutner wrote:
> On Wednesday 23 December 2009 09:52:47 you wrote:
>    
>> It looks like a problem in the Xen library?  Or maybe we're including
>> the library twice.
>>
>> There's no unlock_pages in qemu.
>>
>> Can you rerun with V=1 to see the full command line?
>>      
> Please see here: http://pastebin.com/f4d79c982
>
> (make -j8 vs. just make doesn't make a difference, tested that)...
>
>    

Please post a full log, after 'make clean'.

-- 
error compiling committee.c: too many arguments to function

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Thomas Treutner]

On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
> Please post a full log, after 'make clean'.

http://pastebin.com/f404c8648



kr,t

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Avi Kivity]

On 12/23/2009 12:58 PM, Thomas Treutner wrote:
> On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
>    
>> Please post a full log, after 'make clean'.
>>      
> http://pastebin.com/f404c8648
>
>    

Oh, I missed it at first - looks like libxenguest and libxenctrl conflict.

Copying Gerd for an opinion.

-- 
error compiling committee.c: too many arguments to function

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Gerd Hoffmann]

On 12/23/09 12:37, Avi Kivity wrote:
> On 12/23/2009 12:58 PM, Thomas Treutner wrote:
>> On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
>>> Please post a full log, after 'make clean'.
>> http://pastebin.com/f404c8648
>>
>
> Oh, I missed it at first - looks like libxenguest and libxenctrl conflict.

Indeed, there are (un)lock_pages functions in both libraries.  It is 
fixed in xen 3.3+, where libxenguest doesn't has these functions any more.

/me also wonders why Debian seems to have only static xen libraries.
I think when linking against the shared libraries avoids this too as the 
functions are supposed to be library-internal.

> Copying Gerd for an opinion.

I think there isn't much we can do about this, it is clearly a xen bug.

Uhm, well, while thinking about it:  The test app compiled and linked by 
configure should have failed in a simliar way, thereby automatically 
disabling xen support.  I have no idea why it didn't ...

cheers,
   Gerd

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

[Michael S. Tsirkin]

On Mon, Jan 04, 2010 at 04:22:25PM +0100, Gerd Hoffmann wrote:
> On 12/23/09 12:37, Avi Kivity wrote:
>> On 12/23/2009 12:58 PM, Thomas Treutner wrote:
>>> On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
>>>> Please post a full log, after 'make clean'.
>>> http://pastebin.com/f404c8648
>>>
>>
>> Oh, I missed it at first - looks like libxenguest and libxenctrl conflict.
>
> Indeed, there are (un)lock_pages functions in both libraries.  It is  
> fixed in xen 3.3+, where libxenguest doesn't has these functions any 
> more.
>
> /me also wonders why Debian seems to have only static xen libraries.
> I think when linking against the shared libraries avoids this too as the  
> functions are supposed to be library-internal.
>
>> Copying Gerd for an opinion.
>
> I think there isn't much we can do about this, it is clearly a xen bug.
>
> Uhm, well, while thinking about it:  The test app compiled and linked by  
> configure should have failed in a simliar way, thereby automatically  
> disabling xen support.  I have no idea why it didn't ...

"static library" is in fact just an archive of objects.
If you happen not to pull in the conflicting objects,
you won't see the conflict.
So test file would have to call lock_pages/unlock_pages
for config to detect the issue.

> cheers,
>   Gerd
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html