From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] slow_map: minor improvements to ROM BAR handling Date: Tue, 22 Dec 2009 17:23:28 +0200 Message-ID: <4B30E470.2030001@redhat.com> References: <20091222111044.GA16000@redhat.com> <4B30B603.8080707@suse.de> <20091222124311.GD16165@redhat.com> <4B30CAF2.4040409@suse.de> <20091222151911.GC18541@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40950 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbZLVPXb (ORCPT ); Tue, 22 Dec 2009 10:23:31 -0500 In-Reply-To: <20091222151911.GC18541@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/22/2009 05:19 PM, Michael S. Tsirkin wrote: > >> I'm not sure the BIOS is the only one executing ROMs. If it is, then I'm >> good with the change. >> Maybe it'd make sense to also add a read only flag so we don't >> accidently try to write to the ROM region with slow_map. >> >> Alex >> > Correct: I think it's made readonly down the road with mprotect, > so attempt to do so will crash qemu :) > Alex, are you happy with this? I'd like to apply it. -- error compiling committee.c: too many arguments to function