From: Alexander Graf <agraf@suse.de>
To: Avi Kivity <avi@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] slow_map: minor improvements to ROM BAR handling
Date: Tue, 22 Dec 2009 16:24:43 +0100 [thread overview]
Message-ID: <4B30E4BB.8000507@suse.de> (raw)
In-Reply-To: <4B30E470.2030001@redhat.com>
Avi Kivity wrote:
> On 12/22/2009 05:19 PM, Michael S. Tsirkin wrote:
>>
>>> I'm not sure the BIOS is the only one executing ROMs. If it is, then
>>> I'm
>>> good with the change.
>>> Maybe it'd make sense to also add a read only flag so we don't
>>> accidently try to write to the ROM region with slow_map.
>>>
>>> Alex
>>>
>> Correct: I think it's made readonly down the road with mprotect,
>> so attempt to do so will crash qemu :)
>>
>
> Alex, are you happy with this? I'd like to apply it.
I'd like to see the read-only protection in. Apart from that I'm good on
checking it in, though I'm only awaiting the day someone runs code off
such a ROM region ;-).
Alex
next prev parent reply other threads:[~2009-12-22 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 11:10 [PATCH] slow_map: minor improvements to ROM BAR handling Michael S. Tsirkin
2009-12-22 12:05 ` Alexander Graf
2009-12-22 12:43 ` Michael S. Tsirkin
2009-12-22 13:34 ` Alexander Graf
2009-12-22 15:19 ` Michael S. Tsirkin
2009-12-22 15:23 ` Avi Kivity
2009-12-22 15:24 ` Alexander Graf [this message]
2009-12-22 15:28 ` Michael S. Tsirkin
2009-12-22 15:36 ` Alexander Graf
2009-12-22 15:39 ` Avi Kivity
2009-12-22 15:41 ` Alexander Graf
2009-12-22 15:47 ` Avi Kivity
2009-12-22 16:00 ` Alexander Graf
2009-12-22 16:05 ` Michael S. Tsirkin
2009-12-22 16:10 ` Alexander Graf
2009-12-23 9:07 ` Avi Kivity
2009-12-23 9:15 ` Michael S. Tsirkin
2009-12-23 9:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B30E4BB.8000507@suse.de \
--to=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox