From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH] slow_map: minor improvements to ROM BAR handling
Date: Tue, 22 Dec 2009 16:24:43 +0100
Message-ID: <4B30E4BB.8000507@suse.de>
References: <20091222111044.GA16000@redhat.com> <4B30B603.8080707@suse.de> <20091222124311.GD16165@redhat.com> <4B30CAF2.4040409@suse.de> <20091222151911.GC18541@redhat.com> <4B30E470.2030001@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "Michael S. Tsirkin" <mst@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor.suse.de ([195.135.220.2]:43130 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751511AbZLVPYo (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 22 Dec 2009 10:24:44 -0500
In-Reply-To: <4B30E470.2030001@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
> On 12/22/2009 05:19 PM, Michael S. Tsirkin wrote:
>>
>>> I'm not sure the BIOS is the only one executing ROMs. If it is, then
>>> I'm
>>> good with the change.
>>> Maybe it'd make sense to also add a read only flag so we don't
>>> accidently try to write to the ROM region with slow_map.
>>>
>>> Alex
>>>      
>> Correct: I think it's made readonly down the road with mprotect,
>> so attempt to do so will crash qemu :)
>>    
>
> Alex, are you happy with this?  I'd like to apply it.

I'd like to see the read-only protection in. Apart from that I'm good on
checking it in, though I'm only awaiting the day someone runs code off
such a ROM region ;-).

Alex