From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] slow_map: minor improvements to ROM BAR handling Date: Wed, 23 Dec 2009 11:07:29 +0200 Message-ID: <4B31DDD1.3070702@redhat.com> References: <20091222111044.GA16000@redhat.com> <4B30B603.8080707@suse.de> <20091222124311.GD16165@redhat.com> <4B30CAF2.4040409@suse.de> <20091222151911.GC18541@redhat.com> <4B30E470.2030001@redhat.com> <4B30E4BB.8000507@suse.de> <20091222152806.GA18676@redhat.com> <4B30E783.7080903@suse.de> <4B30E82A.5030702@redhat.com> <4B30E891.9050908@suse.de> <4B30EA14.7020207@redhat.com> <4B30ED34.2000000@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8458 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754231AbZLWJHe (ORCPT ); Wed, 23 Dec 2009 04:07:34 -0500 In-Reply-To: <4B30ED34.2000000@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 12/22/2009 06:00 PM, Alexander Graf wrote: >> Plus, you have a fixed length instruction length, likely more regular >> too. I imagine powerpc is load/store, so you don't have to emulate a >> zillion ALU instructions? >> > Well, it's certainly doable (and easier than on x86). But I'm on the > same position as you on the x86 side. Why increase the emulator size at > least 10 times if we don't have to? > I'm not suggesting you do, just expressing envy. > Either way, people will report bugs when / if they actually start > executing code off MMIO. So let's not care too much about it for now. > Just make sure the read-only check is in. > Yah. -- error compiling committee.c: too many arguments to function