From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Glauber de Oliveira Costa <gcosta@redhat.com>,
Sheng Yang <sheng@linux.intel.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 0/6 v2] Add support for RDTSCP in VMX
Date: Wed, 23 Dec 2009 15:44:48 +0200 [thread overview]
Message-ID: <4B321ED0.9070708@redhat.com> (raw)
In-Reply-To: <20091223133740.GA13991@amt.cnet>
On 12/23/2009 03:37 PM, Marcelo Tosatti wrote:
>
>> Should be automatic. After all, we expose all the MSR list, so qemu can
>> read it and save everything there.
>>
> Hum, thinking a bit more about this (and reading Glauber's previous attempt) its not
> entirely clear that using the list provided by KVM_GET_MSR_INDEX_LIST to automatically save/restore
> is a good thing:
>
> - The MSR must be saved in QEMU's CPUState representation, and its
> likely that it won't exist prior to the addition there.
>
> - What about savevm/loadvm versioning? Currently the QEMU migration
> protocol is unable to deal with a new kernel that supports, for example,
> MSR_TSC_AUX vs a kernel that does not (in case MSRs were automatically
> saved), with the same qemu-kvm version.
>
You're right.
Well, qemu knows about cpuid.rdtscp, so we can add it to vmstate if it
is enabled. We should probably whitelist flags in qemu in the same way
we whitelist them in kvm.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-12-23 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 8:48 [PATCH 0/6 v2] Add support for RDTSCP in VMX Sheng Yang
2009-12-18 8:48 ` [PATCH 1/6] KVM: VMX: Remove redundant variable Sheng Yang
2009-12-18 8:48 ` [PATCH 2/6] x86: Add IA32_TSC_AUX MSR Sheng Yang
2009-12-18 8:48 ` [PATCH 3/6] KVM: Extended shared_msr_global to per CPU Sheng Yang
2009-12-18 8:48 ` [PATCH 4/6] x86: Raise vsyscall priority on hotplug notifier chain Sheng Yang
2009-12-18 8:48 ` [PATCH 5/6] KVM: Add cpuid_update() callback to kvm_x86_ops Sheng Yang
2009-12-18 8:48 ` [PATCH 6/6] KVM: VMX: Add instruction rdtscp support for guest Sheng Yang
2009-12-20 9:30 ` [PATCH 0/6 v2] Add support for RDTSCP in VMX Avi Kivity
2009-12-22 17:26 ` Marcelo Tosatti
2009-12-22 18:26 ` Avi Kivity
2009-12-23 13:37 ` Marcelo Tosatti
2009-12-23 13:44 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B321ED0.9070708@redhat.com \
--to=avi@redhat.com \
--cc=gcosta@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox