From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH master, stable-0.12] linuxboot: fix gdt address calculation Date: Thu, 24 Dec 2009 14:56:40 +0100 Message-ID: <4B337318.6080901@redhat.com> References: <1261661930-11888-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Marcelo Tosatti To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1126 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbZLXN4r (ORCPT ); Thu, 24 Dec 2009 08:56:47 -0500 In-Reply-To: <1261661930-11888-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/24/2009 02:38 PM, Avi Kivity wrote: > The gdt address calculation in linuxboot.bin is broken in two ways: first > it loads %cs into %eax, but that instruction leaves the high bits of %eax > undefined and we did not clear them. Secondly, we completely ignore the > incorrect %eax, and use the undefined %ebx instead. > > With these issues fixed, linuxboot works again. Wow, I wonder how it worked for me... Paolo