Re: [PATCH] KVM: Fix race between APIC TMR and IRR

[Avi Kivity <avi@redhat.com>]

On 12/30/2009 12:09 AM, Marcelo Tosatti wrote:
> On Tue, Dec 29, 2009 at 12:42:16PM +0200, Avi Kivity wrote:
>    
>> When we queue an interrupt to the local apic, we set the IRR before the TMR.
>> The vcpu can pick up the IRR and inject the interrupt before setting the TMR,
>> and perhaps even EOI it, causing incorrect behaviour.
>>
>> The race is really insignificant since it can only occur on the first
>> interrupt (usually following interrupts will not change TMR), but it's better
>> closed than open.
>>      
> The EOI handler clears TMR, so AFAICS it can occur not only on the first
> interrupt.
>    

In that case, we ought to queue it for .33 and -stable.

-- 
error compiling committee.c: too many arguments to function