From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/5] KVM: Lazify fpu activation and deactivation Date: Wed, 06 Jan 2010 13:00:55 +0200 Message-ID: <4B446D67.5050606@redhat.com> References: <1262190342-18611-1-git-send-email-avi@redhat.com> <1262190342-18611-5-git-send-email-avi@redhat.com> <20100106002529.GA11233@amt.cnet> <4B4400F5.2010309@redhat.com> <20100106104744.GJ14679@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Sheng Yang , kvm@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13888 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754246Ab0AFLA7 (ORCPT ); Wed, 6 Jan 2010 06:00:59 -0500 In-Reply-To: <20100106104744.GJ14679@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/06/2010 12:47 PM, Joerg Roedel wrote: > On Wed, Jan 06, 2010 at 05:18:13AM +0200, Avi Kivity wrote: > >> Joerg, what was the reason the initial npt implementation did not do >> lazy fpu switching? >> > The lazy fpu switching code needed cr3 accesses to be intercepted. With > NPT this was the only reason left to intercept cr3 so I decided to > switch lazy fpu switching off and don't intercept cr3 accesses. > Oh. In fact the interaction of cr3 intercepts with lazy fpu was a mistake which this patchset removes; I'll replace cr0 intercepts with selective cr0 write intercept in a new patch. -- error compiling committee.c: too many arguments to function