From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: CPU hotplug add seems broken Date: Mon, 11 Jan 2010 12:50:05 +0200 Message-ID: <4B4B025D.1020309@redhat.com> References: <5e93dcec1001080235r6b3de506q8b2ba132fa1ff52c@mail.gmail.com> <20100109193011.GA25426@defiant.freesoftware> <20100110063911.GG4905@redhat.com> <5e93dcec1001100033tdb930eqcaf48a36ee36b335@mail.gmail.com> <20100110084353.GI4905@redhat.com> <5e93dcec1001110124l38d35ef7y4e92aa8b74aa810a@mail.gmail.com> <4B4AFC09.3090909@redhat.com> <20100111102434.GG7549@redhat.com> <4B4AFCB0.1080706@redhat.com> <20100111104213.GH7549@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Ryota Ozaki , dbareiro@gmx.net, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25245 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070Ab0AKKuK (ORCPT ); Mon, 11 Jan 2010 05:50:10 -0500 In-Reply-To: <20100111104213.GH7549@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/11/2010 12:42 PM, Gleb Natapov wrote: >>> >>> That cool, but SVVP complains. >>> >> What's the complaint? Maybe we can fix it instead of rewriting things. >> >> > https://bugzilla.redhat.com/show_bug.cgi?id=49584://bugzilla.redhat.com/show_bug.cgi?id=495844 > Hope it accessible to everyone but if not SVVP complains: > Run "Signed Driver check" of SVVP testing, the (Qemu virtual CPU verison > 0.9.1) has error. > > The only why to fix it that I can see is to not present disabled MADT > entries for Windows and that will require us to provide some kind > of flag to QEMU. The cleanest way is to create disabled MADT entries > only if max-cpus != startup cpus and run Windows only with max-cpus == > startup cpus. The problem is 1) you have to know what is your guest > at startup time 2) will require creation of SSDT for Processors() > on the fly (or precompile them for every value of max-cpus and load > dynamically). Actually there is a third solution that I just thought > about but I need to test it first :). Perhaps loading a processor driver will fix this issue (which driver can also perform the hotplug). > Anyway all those solution do not > guaranty that we will be able to do cpu hotplug on Windows since we > don't yet know what Windows expects. > I'm sure we'll be able to eventually. -- error compiling committee.c: too many arguments to function