From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Date: Tue, 12 Jan 2010 00:22:28 +0100 Message-ID: <4B4BB2B4.2080406@web.de> References: <20100107124449.GY4905@redhat.com> <20100107162427.GF4905@redhat.com> <4B4B7988.5090803@codemonkey.ws> <4B4B8CD4.8090505@web.de> <4B4B99D3.9090705@codemonkey.ws> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigCF6A1BE31044B5C4CEE3018A" Cc: Gleb Natapov , qemu-devel@nongnu.org, kvm-devel , Avi Kivity , Marcelo Tosatti To: Anthony Liguori Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:45927 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603Ab0AKXWg (ORCPT ); Mon, 11 Jan 2010 18:22:36 -0500 In-Reply-To: <4B4B99D3.9090705@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCF6A1BE31044B5C4CEE3018A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > On 01/11/2010 02:40 PM, Jan Kiszka wrote: >> Anthony Liguori wrote: >> =20 >>> On 01/07/2010 10:24 AM, Gleb Natapov wrote: >>> =20 >>>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >>>> index 4084503..6a841de 100644 >>>> --- a/target-i386/kvm.c >>>> +++ b/target-i386/kvm.c >>>> @@ -17,6 +17,7 @@ >>>> #include >>>> >>>> #include >>>> +#include >>>> =20 >>> This breaks the build on a default F12 install because while kvm.h is= >>> present, kvm_para.h is not. This is a hard one to fix. >>> >>> We can default the kvm search path to /lib/modules/$(uname -r)/build,= we >>> can fix the glibc headers and live with it, or we can pull in the kvm= >>> headers into qemu. >>> >>> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side? >>> =20 >> kvm-kmod-wise, I can include arch and generic kvm_para.h in the next >> release (missed the need for it so far). I'm planning to write a qemu >> patch to ask pkg-config for kvm-kmod headers. >> =20 >=20 > That would be nice. >=20 > I assume a change has to be made in the kernel too so that the libc > headers are updated. IOW, I assume make headers_install doesn't > currently install kvm_para.h I does, I just failed to cherry-pick them from the temporary tree it creates during 'make sync'. Jan --------------enigCF6A1BE31044B5C4CEE3018A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAktLsrsACgkQitSsb3rl5xQDzQCg7fGsisP8AftTHVojhn5tOCmQ DpQAoK4sHA96W+1DpqYF4CyR9VWtuSSz =q/CE -----END PGP SIGNATURE----- --------------enigCF6A1BE31044B5C4CEE3018A--