From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Date: Tue, 12 Jan 2010 10:40:44 +0200 Message-ID: <4B4C358C.2090507@redhat.com> References: <20100107124449.GY4905@redhat.com> <20100107162427.GF4905@redhat.com> <4B4B7988.5090803@codemonkey.ws> <20100112072302.GP7549@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm-devel , Jan Kiszka , Marcelo Tosatti To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21188 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797Ab0ALIku (ORCPT ); Tue, 12 Jan 2010 03:40:50 -0500 In-Reply-To: <20100112072302.GP7549@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/12/2010 09:23 AM, Gleb Natapov wrote: > On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote: > >> On 01/07/2010 10:24 AM, Gleb Natapov wrote: >> >>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >>> index 4084503..6a841de 100644 >>> --- a/target-i386/kvm.c >>> +++ b/target-i386/kvm.c >>> @@ -17,6 +17,7 @@ >>> #include >>> >>> #include >>> +#include >>> >> This breaks the build on a default F12 install because while kvm.h >> is present, kvm_para.h is not. This is a hard one to fix. >> >> > Avi how qemu-kvm compiles there? Or it doesn't? > > include/linux/Kbuild has: ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h \ $(srctree)/include/asm-$(SRCARCH)/kvm.h),) unifdef-y += kvm.h endif ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \ $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),) unifdef-y += kvm_para.h endif So it should be installed. Unfortunately this is starting 2.6.32, so we need to backport the patch (da18acffc3) to the F12 kernel. qemu-kvm doesn't depend on installed headers. -- error compiling committee.c: too many arguments to function