From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Date: Tue, 12 Jan 2010 10:42:54 +0200 Message-ID: <4B4C360E.1080508@redhat.com> References: <20100107124449.GY4905@redhat.com> <20100107162427.GF4905@redhat.com> <4B4B7988.5090803@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , qemu-devel@nongnu.org, kvm-devel , Jan Kiszka , Marcelo Tosatti To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19914 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036Ab0ALIm6 (ORCPT ); Tue, 12 Jan 2010 03:42:58 -0500 In-Reply-To: <4B4B7988.5090803@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 01/11/2010 09:18 PM, Anthony Liguori wrote: > On 01/07/2010 10:24 AM, Gleb Natapov wrote: >> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >> index 4084503..6a841de 100644 >> --- a/target-i386/kvm.c >> +++ b/target-i386/kvm.c >> @@ -17,6 +17,7 @@ >> #include >> >> #include >> +#include > > This breaks the build on a default F12 install because while kvm.h is > present, kvm_para.h is not. This is a hard one to fix. > > We can default the kvm search path to /lib/modules/$(uname -r)/build, > we can fix the glibc headers and live with it, or we can pull in the > kvm headers into qemu. > > Avi/Marcelo/Jan, any thoughts from the qemu-kvm side? > Two options: - make kvm detection depend on kvm_para.h being includable, fix all relevant distro kernels to supply it, and live with the breakage - add a new CONFIG_KVM_PARA, detect it at configure time, and only include it if present -- error compiling committee.c: too many arguments to function