From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/2] kvm: Use kvm-kmod headers if available Date: Tue, 12 Jan 2010 22:22:33 +0100 Message-ID: <4B4CE819.4010402@web.de> References: <4B4CC539.10306@siemens.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB2D22D07D67574AC22DA292C" Cc: Anthony Liguori , Avi Kivity , Marcelo Tosatti , Gleb Natapov , qemu-devel , kvm To: Doug Goldstein Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:53380 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753910Ab0ALVWj (ORCPT ); Tue, 12 Jan 2010 16:22:39 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB2D22D07D67574AC22DA292C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Doug Goldstein wrote: > On Tue, Jan 12, 2010 at 12:53 PM, Jan Kiszka w= rote: >> Since kvm-kmod-2.6.32.2 we have an alternative source for recent KVM >> kernel headers. Use it when available and not overruled by --kerneldir= =2E >> >=20 > Would it be possible to turn this into a configure option? Such that I > could say ./configure --with-kvm-kmod{=3Doptional/path/to} because > otherwise this adds a potential automagical dependency onto kvm-kmod > (i.e. if the user had kvm-kmod installed at the time of build but then > removed them and went back with their kernel provided version) I don't see the problem yet. Either the qemu version built against the previously installed headers will detect during runtime that the loaded kvm support is restricted or even unsuited and handle this properly. Or the user will happen to generate a new qemu which lacks the same features as the installed kvm. There is only the case that the distribution ships more powerful kvm modules than their kernel headers advertise. But that's a distribution bug we can only solve by filing bug reports there and installing kvm-kmod in the meantime. Jan --------------enigB2D22D07D67574AC22DA292C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAktM6BwACgkQitSsb3rl5xTR5ACfdfoI3AW2eLPC8FrCIxuKsbWc 6JYAnjRax3/nJ8lTbn+vv78paQygdgiR =oAwL -----END PGP SIGNATURE----- --------------enigB2D22D07D67574AC22DA292C--