From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: + kvm-ia64-dereference-of-null-pointer-in-set_pal_result.patch added to -mm tree Date: Wed, 13 Jan 2010 11:22:39 +0200 Message-ID: <4B4D90DF.7020700@redhat.com> References: <201001122211.o0CMBSxg030700@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM list , roel.kluin@gmail.com, mtosatti@redhat.com, tony.luck@intel.com, xiantao.zhang@intel.com, "kvm-ia64@vger.kernel.org" To: akpm@linux-foundation.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56381 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753343Ab0AMJWs (ORCPT ); Wed, 13 Jan 2010 04:22:48 -0500 In-Reply-To: <201001122211.o0CMBSxg030700@imap1.linux-foundation.org> Sender: kvm-owner@vger.kernel.org List-ID: On 01/13/2010 12:11 AM, akpm@linux-foundation.org wrote: > Subject: kvm/ia64: dereference of NULL pointer in set_pal_result() > From: Roel Kluin > > Do not dereference a NULL pointer > > diff -puN arch/ia64/kvm/kvm_fw.c~kvm-ia64-dereference-of-null-pointer-in-set_pal_result arch/ia64/kvm/kvm_fw.c > --- a/arch/ia64/kvm/kvm_fw.c~kvm-ia64-dereference-of-null-pointer-in-set_pal_result > +++ a/arch/ia64/kvm/kvm_fw.c > @@ -75,9 +75,11 @@ static void set_pal_result(struct kvm_vc > struct exit_ctl_data *p; > > p = kvm_get_exit_data(vcpu); > - if (p&& p->exit_reason == EXIT_REASON_PAL_CALL) { > + if (!p) > + return; > + if (p->exit_reason == EXIT_REASON_PAL_CALL) { > p->u.pal_data.ret = result; > - return ; > + return; > } > INIT_PAL_STATUS_UNIMPLEMENTED(p->u.pal_data.ret); > } > kvm_get_exit_data() cannot return a NULL pointer. Where did this come from? -- error compiling committee.c: too many arguments to function