From: Alexander Graf <agraf@suse.de>
To: Chris Wright <chrisw@sous-sol.org>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, Dmitri Seletski <drjoms@gmail.com>,
Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH qemu-kvm] device assignment: default requires IOMMU
Date: Mon, 18 Jan 2010 15:18:09 +0100 [thread overview]
Message-ID: <4B546DA1.4050107@suse.de> (raw)
In-Reply-To: <20091223224020.GB3305@sequoia.sous-sol.org>
Chris Wright wrote:
> [ resend, fixing email header, sorry for duplicate ]
>
> The default mode for device assignment is to rely on an IOMMU for
> proper translations and a functioning device in the guest. The current
> logic makes this requirement advisory, and simply disables the request
> for IOMMU if one is not found on the host. This makes for a confused
> user when the device assignment appears to work, but the device in the
> guest is not functioning (I've seen about a half-dozen reports with
> this failure mode).
>
> Change the logic such that the default requires the IOMMU. Period.
> If the host does not have an IOMMU, device assignment will fail.
>
> This is a user visible change, however I think the current situation is
> simply broken.
>
> And, of course, disabling the IOMMU requirement using the old:
>
> -pcidevice host=[addr],dma=none
>
> or the newer:
>
> -device pci-assign,host=[addr],iommu=0
>
> will do what it always did (not require an IOMMU, and fail to work
> properly).
>
Avi,
could you please cherry-pick this into 0.12-stable?
I don't feel too eager getting 500 bug reports from people who try out
device passthrough with disabled or no IOMMU.
Alex
next prev parent reply other threads:[~2010-01-18 14:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 22:40 [PATCH qemu-kvm] device assignment: default requires IOMMU Chris Wright
2009-12-24 0:45 ` Alexander Graf
2009-12-24 6:51 ` Simon Horman
2009-12-24 6:56 ` Sheng Yang
2009-12-24 7:37 ` Muli Ben-Yehuda
2009-12-24 7:41 ` Simon Horman
2009-12-24 11:35 ` Marcelo Tosatti
2010-01-18 14:18 ` Alexander Graf [this message]
2010-01-18 14:20 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B546DA1.4050107@suse.de \
--to=agraf@suse.de \
--cc=avi@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=drjoms@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox