From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault() Date: Tue, 19 Jan 2010 09:54:44 +0200 Message-ID: <4B556544.5070005@redhat.com> References: <1263545063-10285-1-git-send-email-sheng@linux.intel.com> <201001181732.25678.sheng@linux.intel.com> <4B5446BE.9070009@redhat.com> <201001191106.09684.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38103 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750986Ab0ASHyr (ORCPT ); Tue, 19 Jan 2010 02:54:47 -0500 In-Reply-To: <201001191106.09684.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/19/2010 05:06 AM, Sheng Yang wrote: > >> There are two problems with the kernel failure report. First, it >> doesn't report enough data - registers, surrounding instructions, etc. >> that are needed to explain what is going on. Second, it can flood >> dmesg, which is a pretty bad thing to do. >> > > When you talking about "built-in disassembler", do you talking about > "memsave/objdump" or some other more convenient way for this? > > And maybe we can let QEmu do some dump of the assembler code? > (kvm_show_code()) > In the qemu monitor, type 'x/20i $eip' to get a disassembly of code around the current instruction pointer. >> I have a patch somewhere that adds instruction emulation bytes (both >> successful and failed) to ftrace. That may be useful, perhaps. >> > It would surely help. :) > I'll try to resurrect it. -- error compiling committee.c: too many arguments to function