From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv2 1/3] eventfd: allow atomic read and waitqueue remove Date: Thu, 21 Jan 2010 19:14:05 +0200 Message-ID: <4B588B5D.8050802@redhat.com> References: <20100121162648.GA16458@redhat.com> <4B588B29.2050100@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , mtosatti@redhat.com, kvm@vger.kernel.org, Linux Kernel Mailing List To: Davide Libenzi Return-path: In-Reply-To: <4B588B29.2050100@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 01/21/2010 07:13 PM, Avi Kivity wrote: > > But I think we can solve this in another way in .32: we can clear the > eventfd from irqfd->inject work, which is in process context. The new > stuff is only needed for lockless clearing, no? > I meant atomic clearing, when we inject interrupts from the irqfd atomic context. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.