From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv2 1/3] eventfd: allow atomic read and waitqueue remove Date: Thu, 21 Jan 2010 19:33:02 +0200 Message-ID: <4B588FCE.7030803@redhat.com> References: <20100121162648.GA16458@redhat.com> <4B588B29.2050100@redhat.com> <20100121172336.GA16707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Davide Libenzi , mtosatti@redhat.com, kvm@vger.kernel.org, Linux Kernel Mailing List To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34698 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942Ab0AURdG (ORCPT ); Thu, 21 Jan 2010 12:33:06 -0500 In-Reply-To: <20100121172336.GA16707@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/21/2010 07:23 PM, Michael S. Tsirkin wrote: > >> I agree. >> >> But I think we can solve this in another way in .32: we can clear the >> eventfd from irqfd->inject work, which is in process context. The new >> stuff is only needed for lockless clearing, no? >> > No, AFAIK there's no way to clear the counter from kernel without > this patch. > Can't you read from the file? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.