From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Pass cr0.mp through to the guest when the fpu is active Date: Sun, 24 Jan 2010 16:31:17 +0200 Message-ID: <4B5C59B5.5040406@redhat.com> References: <1264343200-16913-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10587 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342Ab0AXObT (ORCPT ); Sun, 24 Jan 2010 09:31:19 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0OEVJgS003540 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 24 Jan 2010 09:31:19 -0500 In-Reply-To: <1264343200-16913-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/24/2010 04:26 PM, Avi Kivity wrote: > When cr0.mp is clear, the guest doesn't expect a #NM in response to > a WAIT instruction. Because we always keep cr0.mp set, it will get > a #NM, and potentially be confused. > > Fix by keeping cr0.mp set only when the fpu is inactive, and passing > it through when inactive. > Note: since all reasonable guests set cr0.mp, and those that don't shouldn't issue fwait, there's no need to queue this for .33 or stable. -- error compiling committee.c: too many arguments to function