Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

Jan Kiszka
2010-02-02T14:34:00Z

Gleb Natapov wrote:
> On Tue, Feb 02, 2010 at 03:20:02PM +0100, Jan Kiszka wrote:
>> Gleb Natapov wrote:
>>> On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote:
>>>> Setting the boot CPU ID is arch-specific KVM stuff. So push it where it
>>>> belongs to.
>>>>
>>> pc_init1 is also arch-specific, no? TCG should also be able to
>>> have BSP apic_id != 0.
>> But not kvm-specific.
>>
>> I don't understand your second remark. Can you help me how TCG is
>> affected by kvm_set_boot_cpu_id?
>>
> It is not affected right now. It assumes that apic ID of BSP cpu is 0,
> but this limitation does not exists on real HW. So when QEMU will be fixed
> and it will be possible to configure what CPU is BSP this will be the
> pace to do it.

That day pc_init1 (or whatever x86 part) will set the bsp number
somewhere in env or apicstate, and we will transfer that afterwards to kvm.

The point is that kvm_* belongs into kvm[-all].c as far as possible. And
in this case it is possible.

Jan

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux