Re: [PATCH 00/21] qemu-kvm: Hook cleanups and extended use of upstream code

Alexander Graf
2010-02-02T10:52:53Z

On 02.02.2010, at 09:18, Jan Kiszka wrote:

> Let's start with the overall stats:
>
> 31 files changed, 274 insertions(+), 822 deletions(-)
>
> So this series drops far more than 500 lines of redundant code, moving
> qemu-kvm yet a bit closer to upstream.
>
> The other highlight is the simplification of synchronization between
> in-kernel and user space VCPU states. This area used to call a lot of
> problems in the past because it was tricky to get things right,
> specifically during the multi-threaded startup. The new approach pushes
> all the sync work around reset and vmsave/load into generic code, not
> only removing the burden from developers of, say, in-kernel APIC
> support, but also dropping most of our kvm-specific hooks, especially in
> the qemu-kvm tree.
>
> While I tested this on various VMs around, and things look good so far,
> I wouldn't be surprised if there are some regressions remaining,
> specifically in the non-x86 parts that I wasn't able to test or even
> build. Please have a careful look!

The good news on that part is that apart from IA64, all other archs are broken in qemu-kvm anyways, but work on upstream qemu. So moving towards upstream definitely helps here.

Alex