Re: [Qemu-devel] [PATCH] Add assignment operation to config file parser..

Gerd Hoffmann
2010-02-08T13:21:56Z

On 02/07/10 17:24, Anthony Liguori wrote:
> On 02/06/2010 12:59 PM, john cooper wrote:
>> This patch reworks support for both assignment and
>> append in the config file parser. It was motivated
>> by comments received on the cpu model config file
>> format.
>>
>> Commit dc9ca4ba27be4fe6a0284061b8f056c4364fb0d9
>> changed the behavior of "=" from assign to append.
>> This patch preserves the ability to append to an
>> option (however now via "+="), reverts "=" to its
>> previous behavior, and allows both to interoperate.
>>
>> Signed-off-by: john cooper<john.cooper@redhat.com>
>
> This deviates from standard ini syntax which makes me a big
> uncomfortable with it. Gerd, do you have an opinion?

Also it the syntax change will break existing users of the append
feature (host/guestfwd for slirp networking).

Any reason why you can't use the current append to avoid the overlong
feature flag lines?

Another idea: One could reference other processors "base", then you can
define a -- say -- Opteron_G3 as "Opteron_G2 features plus these".

cheers,
Gerd