From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code Date: Wed, 03 Feb 2010 19:02:58 +0100 Message-ID: <4B69BA52.5050006@siemens.com> References: <20100203165051.GA29235@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "kvm@vger.kernel.org" , Anthony Liguori , Alexander Graf , Glauber Costa , "qemu-devel@nongnu.org" To: Marcelo Tosatti Return-path: Received: from goliath.siemens.de ([192.35.17.28]:23632 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932761Ab0BCSDb (ORCPT ); Wed, 3 Feb 2010 13:03:31 -0500 In-Reply-To: <20100203165051.GA29235@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote: >> This version addresses the feedback on v2, namely: >> - assert( || thread>) on low-level >> load/save registers >> - fixed mpstate initialization >> >> Yet untested is -no-kvm-irqchip with smp due to some bug in unpatched >> qemu-kvm or the kernel modules. Still investigating. > > Don't recall it ever working properly. Guess that IPI emulation with > signals is problematic. OK, then it only works by chance on some boxes. Specifically, forcing qemu onto a single host core "solves" the issue - suspicious. > >> Pull URL is still >> >> git://git.kiszka.org/qemu-kvm.git queues/vcpu-state >> >> PS: The corresponding upstream queue is now available under >> queues/kvm-upstream in the same repository. Will send it out later if >> there are no further remarks on this series to avoid flooding the >> mailing lists. Early testers are nevertheless welcome. > > Can the necessary changes for cleanups go in qemu.git first, so after > they're merged in qemu-kvm, we can apply the unification patches. > > And later do the same with synchronization rework (API looks fine to > me). Fine with me. Will send out my upstream queue - against uq/master or directly against qemu.git then? > > Nice work! > Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux