From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 4/4] KVM: Rework of guest debug state writing Date: Thu, 04 Feb 2010 20:00:26 +0100 Message-ID: <4B6B194A.90009@siemens.com> References: <372238c800e0d57815f472502fdf78e53463bbb6.1265232579.git.jan.kiszka@siemens.com> <20100203234929.GA11012@amt.cnet> <4B6A15EE.4050501@web.de> <20100204130038.GA15671@amt.cnet> <4B6AE1E6.9040805@siemens.com> <4B6AEAB8.3030509@siemens.com> <20100204180555.GA3861@amt.cnet> <4B6B179A.3080704@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , "qemu-devel@nongnu.org" , Avi Kivity , "kvm@vger.kernel.org" To: Marcelo Tosatti Return-path: Received: from thoth.sbs.de ([192.35.17.2]:22506 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757861Ab0BDTBA (ORCPT ); Thu, 4 Feb 2010 14:01:00 -0500 In-Reply-To: <4B6B179A.3080704@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Marcelo Tosatti wrote: >> >> Unrelated to this problem, won't put_vcpu_events, which is executed >> after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions? > > Good point, SET_GUEST_DEBUG should be last in the writeback for that reason. Actually, we no longer need the exception injection via SET_GUEST_DEBUG now that we have full access via vcpu_events. So this needs a cleanup, and I'm afraid quite a few cases are broken ATM with vcpu_events writeback overwriting the reinjected exceptions. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux