From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of
 upstream code
Date: Sun, 07 Feb 2010 12:28:49 +0100
Message-ID: <4B6EA3F1.5000405@web.de>
References: <cover.1265187223.git.jan.kiszka@siemens.com> <20100207094641.GH2471@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigF2FB918DFAA10DDF34012FFA"
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, Anthony Liguori <aliguori@us.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fmmailgate03.web.de ([217.72.192.234]:38998 "EHLO
	fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754640Ab0BGL3V (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 7 Feb 2010 06:29:21 -0500
In-Reply-To: <20100207094641.GH2471@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigF2FB918DFAA10DDF34012FFA
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Gleb Natapov wrote:
> On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote:
>> This version addresses the feedback on v2, namely:
>> - assert(<vm stopped> || <current thread =3D=3D env->thread>) on low-l=
evel
>>   load/save registers
>> - fixed mpstate initialization
>>
> With those patched, doing "info cpus" in monitor kill the guest, which,=

> unfortunately, means that reworked VCPU state writeback is still not so=

> easy to use correctly.
>=20

Regression of patch 12 ("qemu-kvm: Use upstream kvm_vcpu_dirty"), will
be fixed in v3.

Thanks,
Jan

---

diff --git a/qemu-kvm.c b/qemu-kvm.c
index 6a72b89..72c2ca0 100644
--- a/qemu-kvm.c
+++ b/qemu-kvm.c
@@ -1532,13 +1532,13 @@ static void do_kvm_cpu_synchronize_state(void *_e=
nv)
     CPUState *env =3D _env;
=20
     kvm_arch_save_regs(env);
+    env->kvm_vcpu_dirty =3D 1;
 }
=20
 void kvm_cpu_synchronize_state(CPUState *env)
 {
     if (!env->kvm_vcpu_dirty) {
         on_vcpu(env, do_kvm_cpu_synchronize_state, env);
-        env->kvm_vcpu_dirty =3D 1;
     }
 }
=20


--------------enigF2FB918DFAA10DDF34012FFA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAktuo/UACgkQitSsb3rl5xTeAwCfYnXifWOr/K/E7ku6LV1C88LC
t7MAnRqfrO8++QGhZ+nv0MWXD41sOR9S
=4qR5
-----END PGP SIGNATURE-----

--------------enigF2FB918DFAA10DDF34012FFA--