Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

Avi Kivity
2010-02-07T14:32:33Z

On 02/07/2010 04:26 PM, Jan Kiszka wrote:
>
>> Well, to me it makes more sense to name them from the point of view of
>> the vcpu that is doing the update.
>>
> I'm open for a better name - except for "sync" as writebacks are always
> synchronous from the POV of the modified VCPU.

I meant that the state itself is synchronous from the POV of the vcpu.
That is, rax can only be changed by the core, but INIT state may be
changed by the other cores.

> Is KVM_PUT_RUNTIME_STATE
> clearer?
>

They're all runtime. I guess this issue will always be confusing, so
best to slap a comment on top of the define to explain it.

--
error compiling committee.c: too many arguments to function