Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code

Marcelo Tosatti
2010-02-03T18:37:46Z

On Wed, Feb 03, 2010 at 07:02:58PM +0100, Jan Kiszka wrote:
> Marcelo Tosatti wrote:
> > On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote:
> >> This version addresses the feedback on v2, namely:
> >> - assert(<vm stopped> || <current thread == env->thread>) on low-level
> >> load/save registers
> >> - fixed mpstate initialization
> >>
> >> Yet untested is -no-kvm-irqchip with smp due to some bug in unpatched
> >> qemu-kvm or the kernel modules. Still investigating.
> >
> > Don't recall it ever working properly. Guess that IPI emulation with
> > signals is problematic.
>
> OK, then it only works by chance on some boxes. Specifically, forcing
> qemu onto a single host core "solves" the issue - suspicious.
>
> >
> >> Pull URL is still
>
> >> git://git.kiszka.org/qemu-kvm.git queues/vcpu-state
> >>
> >> PS: The corresponding upstream queue is now available under
> >> queues/kvm-upstream in the same repository. Will send it out later if
> >> there are no further remarks on this series to avoid flooding the
> >> mailing lists. Early testers are nevertheless welcome.
> >
> > Can the necessary changes for cleanups go in qemu.git first, so after
> > they're merged in qemu-kvm, we can apply the unification patches.
> >
> > And later do the same with synchronization rework (API looks fine to
> > me).
>
> Fine with me. Will send out my upstream queue - against uq/master or
> directly against qemu.git then?

Please send only the cleanups (up to
0160a98b9415603f583aec49b21dbd98b46ac969) for qemu.git for now, since
Avi/others might have comments on the synchronization changes.