From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: VMX: update cr0 read shadow when deactivating cr0.ts passthrough Date: Sun, 07 Feb 2010 13:53:46 +0200 Message-ID: <4B6EA9CA.3060202@redhat.com> References: <20100201164827.GA3225@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7982 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933568Ab0BGLxr (ORCPT ); Sun, 7 Feb 2010 06:53:47 -0500 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o17BrlZR018028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 7 Feb 2010 06:53:47 -0500 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o17BrkVd007537 for ; Sun, 7 Feb 2010 06:53:47 -0500 In-Reply-To: <20100201164827.GA3225@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 02/01/2010 06:48 PM, Marcelo Tosatti wrote: > On fpu deactivation, the cr0 read shadow is not properly updated, since > it assumes vcpu->arch.cr0 contains the guest visible cr0 value before > guest had control of cr0.ts. > > This is not true, since cr0 has been decached (from vmx_fpu_deactivate > itself or somewhere else). > > Fix by unconditionally updating cr0 read shadow (this is not a hot path, > in comparison with entry/exit). > > Fixes FC8 64 install. > Applied, thanks. -- error compiling committee.c: too many arguments to function