From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 7/8] KVM: Optimize kvm_read_cr[04]_bits() Date: Sun, 07 Feb 2010 14:37:38 +0200 Message-ID: <4B6EB412.6090704@redhat.com> References: <1264080712-3981-1-git-send-email-avi@redhat.com> <1264080712-3981-8-git-send-email-avi@redhat.com> <4B6BD63F.1000009@web.de> <4B6EAC88.7000306@redhat.com> <4B6EB32D.3060804@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, Gleb Natapov To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58644 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933297Ab0BGMhj (ORCPT ); Sun, 7 Feb 2010 07:37:39 -0500 In-Reply-To: <4B6EB32D.3060804@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 02/07/2010 02:33 PM, Jan Kiszka wrote: > Avi Kivity wrote: > >> On 02/05/2010 10:26 AM, Jan Kiszka wrote: >> >>> Avi Kivity wrote: >>> >>> >>>> 'mask' is always a constant, so we can check whether it includes a >>>> bit that >>>> might be owned by the guest very cheaply, and avoid the decache >>>> call. Saves >>>> a few hundred bytes of module text. >>>> >>>> >>> -no-kvm-irqchip -smp 2 is broken for my Linux guests since this commit. >>> Their user space applications receive #UD and things fall apart. >>> >>> >>> >> Does 2c8232fc help? >> >> > Nope, unfortunately. > > Which specific guests exhibit the behaviour? -- error compiling committee.c: too many arguments to function