From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API Date: Sun, 07 Feb 2010 15:26:08 +0100 Message-ID: <4B6ECD80.6090407@web.de> References: <4822161334c3e10d7772dbd08dafdd3a78c86ce4.1265187223.git.jan.kiszka@siemens.com> <4B6EC180.7000203@redhat.com> <4B6EC557.9090804@web.de> <4B6EC6EC.4020509@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9AD18C6AA326E5C1D7EC8B88" Cc: Marcelo Tosatti , kvm@vger.kernel.org, Anthony Liguori , Alexander Graf , Glauber Costa , qemu-devel@nongnu.org To: Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:44334 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664Ab0BGO0T (ORCPT ); Sun, 7 Feb 2010 09:26:19 -0500 In-Reply-To: <4B6EC6EC.4020509@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9AD18C6AA326E5C1D7EC8B88 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 02/07/2010 03:51 PM, Jan Kiszka wrote: >> Avi Kivity wrote: >> =20 >>> On 02/03/2010 10:53 AM, Jan Kiszka wrote: >>> =20 >>>> This grand cleanup drops all reset and vmsave/load related >>>> synchronization points in favor of four(!) generic hooks: >>>> >>>> - cpu_synchronize_all_states in qemu_savevm_state_complete >>>> (initial sync from kernel before vmsave) >>>> - cpu_synchronize_all_post_init in qemu_loadvm_state >>>> (writeback after vmload) >>>> - cpu_synchronize_all_post_init in main after machine init >>>> - cpu_synchronize_all_post_reset in qemu_system_reset >>>> (writeback after system reset) >>>> >>>> These writeback points + the existing one of VCPU exec after >>>> cpu_synchronize_state map on three levels of writeback: >>>> >>>> - KVM_PUT_ASYNC_STATE (during runtime, other VCPUs continue to run) >>>> >>>> =20 >>> Wouldn't that be SYNC_STATE (state that is modified by the current vc= pu >>> only)? >>> =20 >> It's async /wrt other VCPUs. They continue to run and may interact wit= h >> this VCPU while updating its state. >> =20 >=20 > Well, to me it makes more sense to name them from the point of view of > the vcpu that is doing the update. I'm open for a better name - except for "sync" as writebacks are always synchronous from the POV of the modified VCPU. Is KVM_PUT_RUNTIME_STATE clearer? Jan --------------enig9AD18C6AA326E5C1D7EC8B88 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAktuzYUACgkQitSsb3rl5xTkMgCbB53E+rQ/IagBs1W0UoJvZtva X5sAn1J+CY8vLFK32rk4QLLvh0xbOZ53 =joxY -----END PGP SIGNATURE----- --------------enig9AD18C6AA326E5C1D7EC8B88--