From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 18/18] KVM: PPC: Implement Paired Single emulation Date: Sun, 07 Feb 2010 18:18:41 +0200 Message-ID: <4B6EE7E1.3000504@redhat.com> References: <1265298925-31954-1-git-send-email-agraf@suse.de> <1265298925-31954-19-git-send-email-agraf@suse.de> <4B6EB716.2080704@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46339 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754648Ab0BGQSp (ORCPT ); Sun, 7 Feb 2010 11:18:45 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 02/07/2010 05:57 PM, Alexander Graf wrote:+ >>> + dprintk(KERN_INFO "FPU Emulator 0x%x ( 0x%llx, 0x%llx, 0x%llx >>> )", inst, >>> + inout[1], inout[2], inout[3]); >>> + >>> + call_stack =&kvmppc_call_stack[(smp_processor_id() * 2)]; >>> + call_stack[0] = inst; >>> + /* call_stack[1] is INS_BLR */ >>> + >>> >> >> Would be easier on the cache to do this per-cpu? > > It is per-cpu. Or do you mean to actually use the PER_CPU definition? > Is that guaranteed to be executable? I meant, per-cpu vmalloc area, but it should be enough to have a per-cpu cache line. -- error compiling committee.c: too many arguments to function