From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH] Add assignment operation to config file parser.. Date: Sun, 07 Feb 2010 10:24:31 -0600 Message-ID: <4B6EE93F.3030406@codemonkey.ws> References: <4B672535.5050303@redhat.com> <4B6DBC01.4060307@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM list , qemu-devel@nongnu.org, "Przywara, Andre" , Mark McLoughlin , Gerd Hoffmann To: john cooper Return-path: Received: from mail-yx0-f193.google.com ([209.85.210.193]:42882 "EHLO mail-yx0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756043Ab0BGQYe (ORCPT ); Sun, 7 Feb 2010 11:24:34 -0500 Received: by yxe31 with SMTP id 31so4917652yxe.21 for ; Sun, 07 Feb 2010 08:24:33 -0800 (PST) In-Reply-To: <4B6DBC01.4060307@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/06/2010 12:59 PM, john cooper wrote: > This patch reworks support for both assignment and > append in the config file parser. It was motivated > by comments received on the cpu model config file > format. > > Commit dc9ca4ba27be4fe6a0284061b8f056c4364fb0d9 > changed the behavior of "=" from assign to append. > This patch preserves the ability to append to an > option (however now via "+="), reverts "=" to its > previous behavior, and allows both to interoperate. > > Signed-off-by: john cooper > This deviates from standard ini syntax which makes me a big uncomfortable with it. Gerd, do you have an opinion? Regards, Anthony Liguori