From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yongjun Subject: [PATCH] KVM: ia64: clear kvm->arch.vioapic if fail to create irq chip Date: Mon, 08 Feb 2010 17:56:44 +0800 Message-ID: <4B6FDFDC.40603@cn.fujitsu.com> References: <4B6FD2DB.9040104@cn.fujitsu.com> <4B6FD377.205@cn.fujitsu.com> <4B6FDB2D.9080707@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti To: kvm@vger.kernel.org Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:58621 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751607Ab0BHJzh (ORCPT ); Mon, 8 Feb 2010 04:55:37 -0500 In-Reply-To: <4B6FDB2D.9080707@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: If fail to create irq chip due to fail of kvm_setup_default_irq_routing(), kvm->arch.vioapic is not set to NULL, this may cause KVM_GET_IRQCHIP and KVM_SET_IRQCHIP access to unexcepted memory. Signed-off-by: Wei Yongjun --- arch/ia64/kvm/kvm-ia64.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/ia64/kvm/kvm-ia64.c b/arch/ia64/kvm/kvm-ia64.c index 0618898..0cfc15d 100644 --- a/arch/ia64/kvm/kvm-ia64.c +++ b/arch/ia64/kvm/kvm-ia64.c @@ -969,6 +969,7 @@ long kvm_arch_vm_ioctl(struct file *filp, r = kvm_setup_default_irq_routing(kvm); if (r) { kfree(kvm->arch.vioapic); + kvm->arch.vioapic = NULL; goto out; } break; -- 1.6.3.3