From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling Date: Wed, 10 Feb 2010 15:20:14 +0200 Message-ID: <4B72B28E.6010801@redhat.com> References: <4B728FF9.6010707@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" , mtosatti@redhat.com, Anthony Liguori To: OHMURA Kei Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48177 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934Ab0BJNUf (ORCPT ); Wed, 10 Feb 2010 08:20:35 -0500 In-Reply-To: <4B728FF9.6010707@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 02/10/2010 12:52 PM, OHMURA Kei wrote: > dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. > But We think that dirty-bitmap-traveling by long size is faster than by byte > size especially when most of memory is not dirty. > > --- a/bswap.h > +++ b/bswap.h > @@ -209,7 +209,6 @@ static inline void cpu_to_be32wu(uint32_t *p, uint32_t v) > #define cpu_to_32wu cpu_to_le32wu > #endif > > -#undef le_bswap > #undef be_bswap > #undef le_bswaps > Anthony, is it okay to export le_bswap this way, or will you want leul_to_cpu()? -- error compiling committee.c: too many arguments to function