From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling Date: Wed, 10 Feb 2010 18:43:18 +0200 Message-ID: <4B72E226.9010100@redhat.com> References: <4B728FF9.6010707@lab.ntt.co.jp> <4B72B28E.6010801@redhat.com> <4B72D69D.7050005@codemonkey.ws> <4B72D838.9060603@suse.de> <4B72E051.8090008@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: Alexander Graf , OHMURA Kei , mtosatti@redhat.com, "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Anthony Liguori To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61049 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754796Ab0BJQna (ORCPT ); Wed, 10 Feb 2010 11:43:30 -0500 In-Reply-To: <4B72E051.8090008@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 02/10/2010 06:35 PM, Anthony Liguori wrote: > On 02/10/2010 10:00 AM, Alexander Graf wrote: > >> On PPC the bitmap is Little Endian. >> >> > Out of curiousity, why? It seems like an odd interface. > > Exactly this issue. If you specify it as unsigned long native endian, there is ambiguity between 32-bit and 64-bit userspace. If you specify it as uint64_t native endian, you have an inefficient implementation on 32-bit userspace. So we went for unsigned byte native endian, which is the same as any size little endian. (well I think the real reason is that it just grew that way out of x86, but the above is quite plausible). -- error compiling committee.c: too many arguments to function