From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: qemu-kvm: do not allow vcpu stop with in progress PIO Date: Wed, 10 Feb 2010 19:08:01 +0200 Message-ID: <4B72E7F1.5030804@redhat.com> References: <20100128190300.414710338@redhat.com> <20100128190411.495771070@redhat.com> <4B6B1D1F.1080701@redhat.com> <20100204213643.GC2766@amt.cnet> <4B6B4031.80008@redhat.com> <20100208224119.GA6516@amt.cnet> <4B710300.7090903@redhat.com> <20100209205805.GA25144@amt.cnet> <4B7259E8.70904@redhat.com> <20100210162523.GD23089@amt.cnet> <4B72E16B.7080704@redhat.com> <4B72E435.6010208@suse.de> <4B72E67A.4060201@redhat.com> <4B72E6EE.7060602@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, quintela@redhat.com, Gleb Natapov To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51537 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213Ab0BJRIE (ORCPT ); Wed, 10 Feb 2010 12:08:04 -0500 In-Reply-To: <4B72E6EE.7060602@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 02/10/2010 07:03 PM, Alexander Graf wrote: > > I see. Yes, that works for PPC Book3S too. We check for signals on the > beginning of vcpu_run. I'm not sure about BookE though. > > Either way - wouldn't it make more sense to just move the check to > generic code? > Well, the check happens very deep in x86 code (vcpu_enter_guest(), during the critical section switching into guest mode). It should be possible to refactor it into a skeleton that does this (and checks vcpu->requests etc.) and calls arch code to do the actual work. A small gain for a lot of churn, but maybe worthwhile. -- error compiling committee.c: too many arguments to function