Re: [PATCH] KVM: x86 emulator: code style cleanup

Avi Kivity
2010-02-11T10:07:19Z

On 02/11/2010 12:06 PM, Gleb Natapov wrote:
> On Thu, Feb 11, 2010 at 12:03:18PM +0200, Avi Kivity wrote:
>
>> On 02/11/2010 12:00 PM, Gleb Natapov wrote:
>>
>>> On Thu, Feb 11, 2010 at 11:12:07AM +0800, Wei Yongjun wrote:
>>>
>>>> Just remove redundant semicolon.
>>>>
>>>> Signed-off-by: Wei Yongjun<yjwei@cn.fujitsu.com>
>>>> ---
>>>> arch/x86/kvm/emulate.c | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
>>>> index 31f4526..8a52616 100644
>>>> --- a/arch/x86/kvm/emulate.c
>>>> +++ b/arch/x86/kvm/emulate.c
>>>> @@ -1012,7 +1012,7 @@ done_prefixes:
>>>> }
>>>>
>>>> if (mode == X86EMUL_MODE_PROT64&& (c->d& No64)) {
>>>> - kvm_report_emulation_failure(ctxt->vcpu, "invalid x86/64 instruction");;
>>>> + kvm_report_emulation_failure(ctxt->vcpu, "invalid x86/64 instruction");
>>>> return -1;
>>>> }
>>>>
>>>>
>>> Shouldn't we inject #UD here?
>>>
>>>
>> If we reenter the guest the cpu will inject #UD by itself.
>>
>>
> But why rely on that instead of make it explicit? We want to have self
> contained emulator.
>
>

Good point.