From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86 emulator: code style cleanup Date: Thu, 11 Feb 2010 12:03:18 +0200 Message-ID: <4B73D5E6.7060407@redhat.com> References: <4B737587.3070301@cn.fujitsu.com> <20100211100028.GM2995@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Wei Yongjun , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753009Ab0BKKDW (ORCPT ); Thu, 11 Feb 2010 05:03:22 -0500 In-Reply-To: <20100211100028.GM2995@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/11/2010 12:00 PM, Gleb Natapov wrote: > On Thu, Feb 11, 2010 at 11:12:07AM +0800, Wei Yongjun wrote: > >> Just remove redundant semicolon. >> >> Signed-off-by: Wei Yongjun >> --- >> arch/x86/kvm/emulate.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c >> index 31f4526..8a52616 100644 >> --- a/arch/x86/kvm/emulate.c >> +++ b/arch/x86/kvm/emulate.c >> @@ -1012,7 +1012,7 @@ done_prefixes: >> } >> >> if (mode == X86EMUL_MODE_PROT64&& (c->d& No64)) { >> - kvm_report_emulation_failure(ctxt->vcpu, "invalid x86/64 instruction");; >> + kvm_report_emulation_failure(ctxt->vcpu, "invalid x86/64 instruction"); >> return -1; >> } >> >> > Shouldn't we inject #UD here? > > If we reenter the guest the cpu will inject #UD by itself. -- error compiling committee.c: too many arguments to function