* [PATCH] qemu-kvm: pcnet APROMWE bit location
@ 2010-02-14 7:30 Chris Kilgour
2010-02-17 9:34 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Chris Kilgour @ 2010-02-14 7:30 UTC (permalink / raw)
To: kvm
I don't subscribe to the list, so please excuse any breach of etiquette.
According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
Signed-off-by: Christopher Kilgour <techie <at> whiterocker.com>
---
diff --git a/hw/pcnet.c b/hw/pcnet.c
index 44b5b31..f889898 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque,
uint32_t addr
printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
#endif
/* Check APROMWE bit to enable write access */
- if (pcnet_bcr_readw(s,2) & 0x80)
+ if (pcnet_bcr_readw(s,2) & 0x100)
s->prom[addr & 15] = val;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qemu-kvm: pcnet APROMWE bit location
2010-02-14 7:30 [PATCH] qemu-kvm: pcnet APROMWE bit location Chris Kilgour
@ 2010-02-17 9:34 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-02-17 9:34 UTC (permalink / raw)
To: Chris Kilgour; +Cc: kvm
On 02/14/2010 09:30 AM, Chris Kilgour wrote:
> I don't subscribe to the list, so please excuse any breach of etiquette.
>
> According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
>
Please send this to the qemu mailing list, qemu-devel@nongnu.org, as
this code is shared between qemu and qemu-kvm. Thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-17 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-14 7:30 [PATCH] qemu-kvm: pcnet APROMWE bit location Chris Kilgour
2010-02-17 9:34 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox