public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP
Date: Sun, 14 Feb 2010 14:29:19 +0100	[thread overview]
Message-ID: <4B77FAAF.50400@web.de> (raw)
In-Reply-To: <4B77F94E.5030103@web.de>

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

Jan Kiszka wrote:
> Avi Kivity wrote:
>> On 02/14/2010 02:43 PM, Gleb Natapov wrote:
>>>> Nice.
>>>>
>>>> [ /me goes updating his manual - September 07... ]
>>>>
>>>>      
>>> I can't find nothing newer then that. What is the link?
>>>    
>> http://www.amd.com/us-en/Processors/DevelopWithAMD/0,,30_2252_875_7044,00.html
>>
> 
> For the records, it's
> 
> http://developer.amd.com/documentation/guides/Pages/default.aspx
> 
> and then
> 
> http://support.amd.com/us/Processor_TechDocs/24593.pdf
> 
> (Your link still points to the previous revision.)
> 
> nRIP is actually useless for our problem. Either SVM has built-in magic
> to push the RIP after the INT3 on the stack or we need a workaround. I
> bet on the latter as our use case may not have been exercised that often
> before (if at all).
> 

On the other hand:

"Injecting an exception (TYPE = 3) with vectors 3 or 4 behaves like a
trap raised by INT3 and INTO instructions, respectively, in which case
the processor checks the DPL of the IDT descriptor before dispatching to
the handler."

Which /might/ also be read that not only the privilege checks are
applied, but also the original trap characteristics. And that case I
would send kudos to AMD. Will test tomorrow.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

      reply	other threads:[~2010-02-14 13:29 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-13  9:31 [PATCH] KVM: VMX: Update instruction length on intercepted BP Jan Kiszka
2010-02-14  7:53 ` Gleb Natapov
2010-02-14 10:26   ` Jan Kiszka
2010-02-14 10:34     ` Gleb Natapov
2010-02-14 10:47       ` Jan Kiszka
2010-02-14 11:15         ` Gleb Natapov
2010-02-14 11:39           ` Jan Kiszka
2010-02-14 14:16             ` Avi Kivity
2010-02-14 16:38               ` Jan Kiszka
2010-02-14 16:44                 ` Avi Kivity
2010-02-14 17:06                   ` Jan Kiszka
2010-02-15  6:48                     ` Avi Kivity
2010-02-14 14:45             ` Gleb Natapov
2010-02-14 16:37               ` Jan Kiszka
2010-02-14 16:53                 ` Gleb Natapov
2010-02-14 17:06                   ` Jan Kiszka
2010-02-14 17:26                     ` Gleb Natapov
2010-02-14 17:49                       ` Jan Kiszka
2010-02-15 13:20                         ` Jan Kiszka
2010-02-15 13:30                           ` Gleb Natapov
2010-02-15 14:25                             ` Jan Kiszka
2010-02-17 11:11                             ` Avi Kivity
2010-02-17 11:13                               ` Gleb Natapov
2010-02-17 11:24                                 ` Jan Kiszka
2010-02-17 12:39                                   ` Gleb Natapov
2010-02-17 10:55                           ` Gleb Natapov
2010-02-17 11:32                             ` Jan Kiszka
2010-02-17 13:03                               ` Gleb Natapov
2010-02-17 15:13                                 ` Jan Kiszka
2010-02-17 16:11                                   ` Gleb Natapov
2010-02-16 11:20                         ` Gleb Natapov
2010-02-16 11:25                           ` Gleb Natapov
2010-02-14 12:27       ` Avi Kivity
2010-02-14 12:39         ` Jan Kiszka
2010-02-14 12:43           ` Gleb Natapov
2010-02-14 12:47             ` Avi Kivity
2010-02-14 12:53               ` Gleb Natapov
2010-02-14 13:23               ` Jan Kiszka
2010-02-14 13:29                 ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B77FAAF.50400@web.de \
    --to=jan.kiszka@web.de \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox