Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP

Avi Kivity
2010-02-14T16:44:33Z

On 02/14/2010 06:38 PM, Jan Kiszka wrote:
> Avi Kivity wrote:
>
>> On 02/14/2010 01:39 PM, Jan Kiszka wrote:
>>
>>>> that will work for both VMX and SVM before applying patches that make
>>>> oly VMX work?
>>>>
>>>>
>>> VMX used to work, so my patch is actually a regression fix. I bet this
>>> was accidentally broken while cleaning up the interrupt handling of VMX.
>>>
>>>
>>>
>> Care to post a test case?
>>
>> I can't say we run the internal test suite at the moment, but it should
>> really be integrated into autotest.
>>
>>
> I know this should have been done long before. I just haven't worked on
> autotest so far (a colleague did, though), so there is some reluctance
> to get wet feet. But maybe I find some rubber boots.
>

The autotest people (Lucas copied) are generally good at adding tests,
so all we need to do is (a) add a test case to
qemu-kvm.git:kvm/user/test (b) indicate to the autotest people how to
build and run this thing.

--
error compiling committee.c: too many arguments to function