From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP Date: Sun, 14 Feb 2010 18:44:31 +0200 Message-ID: <4B78286F.4000103@redhat.com> References: <4B767160.4070609@web.de> <20100214075303.GF2511@redhat.com> <4B77CFD7.9080504@web.de> <20100214103445.GH2511@redhat.com> <4B77D4DE.3030602@web.de> <20100214111544.GJ2511@redhat.com> <4B77E0E2.7030704@web.de> <4B7805D2.7070602@redhat.com> <4B7826F0.8060009@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Marcelo Tosatti , kvm , Lucas Meneghel Rodrigues To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49487 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701Ab0BNQod (ORCPT ); Sun, 14 Feb 2010 11:44:33 -0500 In-Reply-To: <4B7826F0.8060009@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 02/14/2010 06:38 PM, Jan Kiszka wrote: > Avi Kivity wrote: > >> On 02/14/2010 01:39 PM, Jan Kiszka wrote: >> >>>> that will work for both VMX and SVM before applying patches that make >>>> oly VMX work? >>>> >>>> >>> VMX used to work, so my patch is actually a regression fix. I bet this >>> was accidentally broken while cleaning up the interrupt handling of VMX. >>> >>> >>> >> Care to post a test case? >> >> I can't say we run the internal test suite at the moment, but it should >> really be integrated into autotest. >> >> > I know this should have been done long before. I just haven't worked on > autotest so far (a colleague did, though), so there is some reluctance > to get wet feet. But maybe I find some rubber boots. > The autotest people (Lucas copied) are generally good at adding tests, so all we need to do is (a) add a test case to qemu-kvm.git:kvm/user/test (b) indicate to the autotest people how to build and run this thing. -- error compiling committee.c: too many arguments to function