From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP Date: Sun, 14 Feb 2010 18:06:40 +0100 Message-ID: <4B782DA0.5030301@web.de> References: <4B767160.4070609@web.de> <20100214075303.GF2511@redhat.com> <4B77CFD7.9080504@web.de> <20100214103445.GH2511@redhat.com> <4B77D4DE.3030602@web.de> <20100214111544.GJ2511@redhat.com> <4B77E0E2.7030704@web.de> <4B7805D2.7070602@redhat.com> <4B7826F0.8060009@web.de> <4B78286F.4000103@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig772D7068AACDC7A0AE9E47FE" Cc: Gleb Natapov , Marcelo Tosatti , kvm , Lucas Meneghel Rodrigues To: Avi Kivity Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:49935 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998Ab0BNRHC (ORCPT ); Sun, 14 Feb 2010 12:07:02 -0500 In-Reply-To: <4B78286F.4000103@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig772D7068AACDC7A0AE9E47FE Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 02/14/2010 06:38 PM, Jan Kiszka wrote: >> Avi Kivity wrote: >> =20 >>> On 02/14/2010 01:39 PM, Jan Kiszka wrote: >>> =20 >>>>> that will work for both VMX and SVM before applying patches that ma= ke >>>>> oly VMX work? >>>>> >>>>> =20 >>>> VMX used to work, so my patch is actually a regression fix. I bet th= is >>>> was accidentally broken while cleaning up the interrupt handling of >>>> VMX. >>>> >>>> >>>> =20 >>> Care to post a test case? >>> >>> I can't say we run the internal test suite at the moment, but it shou= ld >>> really be integrated into autotest. >>> >>> =20 >> I know this should have been done long before. I just haven't worked o= n >> autotest so far (a colleague did, though), so there is some reluctance= >> to get wet feet. But maybe I find some rubber boots. >> =20 >=20 > The autotest people (Lucas copied) are generally good at adding tests, > so all we need to do is (a) add a test case to > qemu-kvm.git:kvm/user/test (b) indicate to the autotest people how to > build and run this thing. I wonder if it requires a stand-alone test. So far I'm testing the guest side via gdb installed in some Linux image. We need to interact with gdb anyway to test guest debugging, so this would just add another instance and some indirection (via serial console or ssh into the guest). Jan --------------enig772D7068AACDC7A0AE9E47FE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkt4LaAACgkQitSsb3rl5xRNOgCeOlCivkRSSONkblQJtCJBiF+y 4SEAn2c6opHbk5mJy+v2pAhu8LRDKrDk =QF74 -----END PGP SIGNATURE----- --------------enig772D7068AACDC7A0AE9E47FE--