From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: x86: Save&restore interrupt shadow mask
Date: Mon, 15 Feb 2010 08:33:58 +0200
Message-ID: <4B78EAD6.2060204@redhat.com>
References: <4B782980.8070300@web.de> <4B782B66.4090205@redhat.com> <4B782D7F.2040102@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:18612 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752031Ab0BOGeB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 15 Feb 2010 01:34:01 -0500
In-Reply-To: <4B782D7F.2040102@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 02/14/2010 07:06 PM, Jan Kiszka wrote:
>> Needs a KVM_CAP_ and flags bit.
>>      
> Why if merged before 2.6.33? We haven't released KVM_CAP_VCPU_EVENTS yet.
>    

Userspace already knows the interrupt shadow mask free variant.  Maybe 
it all works out, but KVM_CAP_ bits are cheaper than checking (and 
possibly getting it wrong).

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.